[Code Review] Team 02 - Hw04

/*********************** Form1.cs ************************/
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using Q4;

namespace HW4
{
    public partial class Form1 : Form
    {
        CardDeck deck = new CardDeck();

        public Form1()
        {
            InitializeComponent();            
            deck.CreateDeck();
            deck.ResetDeck();
        }

        private void btn_cmoSelect_Click(object sender, EventArgs e)
        {
            switch(cbo_Select.SelectedIndex)
            {
                case 0:
                    txt_Display.AppendText("Combobox 按花色牌列 已被選定\n");
                    deck.ResetDeck();
                    ShowDeck(deck);
                    break;
                case 1:
                    txt_Display.AppendText("Combobox 亂數排列 已被選定\n");
                    deck.Shuffle();
                    ShowDeck(deck);
                    break;
                case 2:
                    txt_Display.AppendText("Combobox 按點數牌列 已被選定\n");
                    deck.OrderByRank();
                    ShowDeck(deck);
                    break;
                default:
                    txt_Display.AppendText("請重新選擇!\n");
                    break;
            }
        }

        private void btn_chkSelect_Click(object sender, EventArgs e)
        {
            if (chk_ResetDeck.Checked)
            {
                txt_Display.AppendText("Checkbox 按花色牌列 已被選定\n");
                deck.ResetDeck();
                ShowDeck(deck);
            }
            if (chk_Shuffle.Checked)
            {
                txt_Display.AppendText("Checkbox 亂數排列 已被選定\n");
                deck.Shuffle();
                ShowDeck(deck);
            }
            if (chk_OrderByRank.Checked)
            {
                txt_Display.AppendText("Checkbox 按點數牌列 已被選定\n");
                deck.OrderByRank();
                ShowDeck(deck);
            }
        }

        private void ShowDeck(CardDeck deck)
        {
            string s = "";
            for (int i = 0; i < 52; i++)
            {
                s += deck.Cards[i].RankToStr() + deck.Cards[i].SuitToAscii() + "  ";
                if (i % 13 == 12)
                {
                    s += "\n";
                }
            }
            MessageBox.Show(s);
        }
    }
}

/*********************** CardDeck.cs ************************/
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace Q4
{
    class CardDeck
    {
        public int CardNum  = 52;
        public PokerCard[] Cards;

        public CardDeck()
        { 
            Cards = new PokerCard[CardNum];
        }
        public void CreateDeck()  //產生出52個PokerCard的物件
        {
            for (int i = 0; i < CardNum; i++)
            {
                Cards[i] = new PokerCard();
            }
        }
        public void ResetDeck() //牌堆回復原始狀態
        {
            for (int i = 0; i < CardNum; i++)
            {
                Cards[i].Suit = i / 13 + 3;
                Cards[i].Rank = i % 13 + 1;
            }
        }
        public void Shuffle() //洗牌
        {
            Random rand = new Random();
            int RandNum = 0;
            PokerCard TempCard = new PokerCard();
            for (int i = 0; i < CardNum; i++)
            {
                RandNum = rand.Next(CardNum);
                TempCard = Cards[RandNum];
                Cards[RandNum] = Cards[i];
                Cards[i] = TempCard;
            }
        }
        public void OrderByRank() //依點數排序
        {
            for (int i = 0; i < CardNum; i++)
            {
                Cards[i].Suit = i % 4 + 3;
                Cards[i].Rank = i / 4 + 1;
            }
        } 
    }
}

/*********************** PokerCard.cs ************************/
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace Q4
{
    class PokerCard
    {
        public int Suit = 0;  //花色
        public int Rank = 0;  //點數

        public string RankToStr()  //將點數轉為字串
        { 
// 不好的寫法
/*            string[] num = {"A","2","3","4","5","6","7","8","9","10","J","Q","K"};
            return num[Rank];*/

// 較佳的寫法
            switch (Rank)
            {
                case 1:
                    return "A";
                case 2:
                case 3:
                case 4:
                case 5:
                case 6:
                case 7:
                case 8:
                case 9:
                case 10:
                    return Convert.ToString(Rank);
                case 11:
                    return "J";
                case 12:
                    return "Q";
                case 13:
                    return "K";
                default:
                    return "NULL";
            }
        }
        public string SuitToAscii()  //將花色轉為 Ascii 字元碼
        {
            switch (Suit)
            {
                case 3:
                    return "♥";
                case 4:
                    return "♦";
                case 5:
                    return "♣";
                case 6:
                    return "♠";
                default:
                    return "";
            }

        }
    }

}